Allow default http client connection to read simple streamed responses#89
Merged
asfgit merged 1 commit intoapache:masterfrom Oct 11, 2018
Merged
Allow default http client connection to read simple streamed responses#89asfgit merged 1 commit intoapache:masterfrom
asfgit merged 1 commit intoapache:masterfrom
Conversation
As per spec these responses are terminated by the end of stream. Issue: HTTPCORE-559
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per spec these responses are terminated by the end of stream.
Issue: https://issues.apache.org/jira/browse/HTTPCORE-559
Note: this PR breaks one existing unit test - namely {{testReadResponseNoEntity}} from {{TestDefaultBHttpClientConnection}}. The test is trivial to fix, but I'm not sure what you want the desired behaviour to be when an 'empty' response is returned. Previously the result was a null entity, but with my change the result is now an empty entity, an entity with no content. I think this is fine, but you may not.