Skip to content

acinclude.m4: test for OPENSSL_NO_ENGINE#384

Closed
orbea wants to merge 1 commit intoapache:trunkfrom
orbea:libressl-3.8.1
Closed

acinclude.m4: test for OPENSSL_NO_ENGINE#384
orbea wants to merge 1 commit intoapache:trunkfrom
orbea:libressl-3.8.1

Conversation

@orbea
Copy link

@orbea orbea commented Sep 7, 2023

With >= LibreSSL 3.8.1 the engine code has been removed and OPENSSL_NO_ENGINE has been defined, testing for this define during configure will prevent implicit function declarations when using an ssl implementation with the engine code disabled or removed.

@orbea orbea force-pushed the libressl-3.8.1 branch 2 times, most recently from a48cff3 to 1a43bec Compare September 7, 2023 20:42
With >= LibreSSL 3.8.1 the engine code has been removed and
OPENSSL_NO_ENGINE has been defined, testing for this define during
configure will prevent implicit function declarations when using an ssl
implementation with the engine code disabled or removed.
gentoo-bot pushed a commit to gentoo/libressl that referenced this pull request Sep 7, 2023
Upstream-PR: apache/httpd#384
Signed-off-by: orbea <orbea@riseup.net>
@notroj
Copy link
Collaborator

notroj commented Jan 5, 2024

Can you test whether this works with current trunk? I think this was likely fixed in 1e06568

@orbea
Copy link
Author

orbea commented Jan 5, 2024

@notroj I tested the current trunk (c902858) which worked, then I tested that commit (1e06568) which failed....

I then checked the 2.4.58 tag which matches the version in Gentoo, this also fails to build. Lastly I bisected between the trunk and the 1e06568 commit and found the commit that fixed this was 922d6bb. This is a similar fix to what I was doing here so I'll close this now.

Thanks for the reply!

For reference my build command was:

export CFLAGS="-O2 -pipe -Werror=implicit-function-declaration"
./buildconf --with-apr=../apr-1.7.4 --with-apr-util=../apr-util-1.6.3 && ./configure && make

@orbea orbea closed this Jan 5, 2024
@notroj
Copy link
Collaborator

notroj commented Jan 5, 2024

Thanks a lot for testing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants