Concrete signature of HoodieRecordPayload#combineAndGetUpdateValue & HoodieRecordPayload#getInsertValue

[hudi-bot]

So far, the return type of {{HoodieRecordPayload#combineAndGetUpdateValue}} & {{HoodieRecordPayload#getInsertValue}} is effectively {{Option}}. Instead of doing unchecked cast at

org/apache/hudi/hadoop/realtime/RealtimeCompactedRecordReader.java:88

I propose we use {{Option}} as the return type of these two method, which replaces current {{Option}}.

FYI, I encounter this ticket when trying to get rid of self type parameter in {{HoodieRecordPayload}} and found that it is a bit awkward if we don't take a self type while doing this casting. Fortunately it is the fact that we can directly concrete it.

cc [~vinoth] [~leesf]

JIRA info

• Link: https://issues.apache.org/jira/browse/HUDI-834
• Type: Improvement

[hudi-bot]

Linked PR(s)

• [WIP] [HUDI-834] Concrete signature of HoodieRecordPayload#combineAndGetUpdateValue & HoodieRecordPayload#getInsertValue #1557