[HUDI-7062] Implement Caching Iterator for new filegroup reader#10036
Merged
yihua merged 2 commits intoapache:masterfrom Nov 9, 2023
Merged
[HUDI-7062] Implement Caching Iterator for new filegroup reader#10036yihua merged 2 commits intoapache:masterfrom
yihua merged 2 commits intoapache:masterfrom
Conversation
yihua
approved these changes
Nov 9, 2023
| this.baseFileIterator = baseFileIterator; | ||
| } | ||
|
|
||
| protected abstract boolean doHasNext() throws IOException; |
Contributor
There was a problem hiding this comment.
Let's add a comment here on why the caching iterator is needed here.
linliu-code
approved these changes
Nov 9, 2023
yihua
approved these changes
Nov 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Sometimes df.count() ends up calling hasnext multiple times before calling next() so we need to use caching iterator style
Impact
fix issue that was causing tests to fail
Risk level (write none, low medium or high below)
low
Documentation Update
N/A
Contributor's checklist