[HUDI-7153] Fixing range overflow with kakfa source and spark partition management#10205
Merged
bvaradar merged 1 commit intoapache:masterfrom Dec 1, 2023
Merged
Conversation
nsivabalan
added
priority:critical
nsivabalan
commented
Nov 29, 2023
|
|
||
| long toOffset = Math.min(range.untilOffset(), range.fromOffset() + eventsPerPartition); | ||
| long toOffset = -1L; | ||
| if (range.fromOffset() + eventsPerPartition > range.fromOffset()) { |
Contributor
Author
There was a problem hiding this comment.
NTR(note to reviewer):
if range.fromOffset() + eventsPerPartition exceeds Long.MAX_VALUE, toOffset will be set to some negative value.
nsivabalan
force-pushed
the
minKafkaPartitionsNegativeOffsets
branch
from
576cb7e to
678b3d7
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Fixing range overflow with kakfa source and spark partition management
Impact
Pipeline will not fail with range overflow errors.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist