[MINOR] Fix violations of Sonarqube rule java:S2184#10444
Merged
yihua merged 2 commits intoapache:masterfrom Mar 1, 2024
Merged
[MINOR] Fix violations of Sonarqube rule java:S2184#10444yihua merged 2 commits intoapache:masterfrom
yihua merged 2 commits intoapache:masterfrom
Conversation
bvaradar
changed the title
Contributor
|
@KUTEJiang : Can you fix the PR to pass the validation |
yihua
changed the title
Contributor
|
@KUTEJiang I fixed the PR description. Please do that yourself next time. |
yihua
approved these changes
Mar 1, 2024
danny0405
approved these changes
Mar 1, 2024
github-actions
bot
added
size:S
Collaborator
yihua
added a commit
that referenced
this pull request
May 14, 2024
Co-authored-by: Y Ethan Guo <ethan.guoyihua@gmail.com>
yihua
added a commit
that referenced
this pull request
May 14, 2024
Co-authored-by: Y Ethan Guo <ethan.guoyihua@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
This PR fixes 4 violations of Sonarqube Rule java:S2184 : 'Math operands should be cast before assignment'.
For more details, please see
MITRE, CWE-190 - Integer Overflow or Wraparound
CERT, NUM50-J.- Convert integers to floating point for floating-point operations
CERT, INT18-C. - Evaluate integer expressions in a larger size before comparing or assigning to that size
The patch was automatically generated using the ViolationFixer tool.
Impact
Code quality improvements.
Risk level
none
Documentation Update
N/A
Contributor's checklist