[HUDI-7445] Move PR size labeling to GitHub scheduled workflow#10761
Merged
yihua merged 1 commit intoapache:masterfrom Feb 27, 2024
Merged
[HUDI-7445] Move PR size labeling to GitHub scheduled workflow#10761yihua merged 1 commit intoapache:masterfrom
yihua merged 1 commit intoapache:masterfrom
Conversation
Collaborator
0f7282f to
09700ae
Compare
Contributor
Author
|
@stream2000 if you have time, you may review and approve another useful workflow logic to have, labeling PR size for planning PR reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
HOTFIX: SKIP AZURE CI
script update only
This PR moves the PR size labeling to the GitHub scheduled workflow, and the labeling logic is now implemented by ourselves instead of relying on third-party library.
The label is added based the lines of changes (LoC) of the PR (additions + deletions):
size:XS: <= 10 LoCsize:S: (10, 100] LoCsize:M: (100, 300] LoCsize:L: (300, 1000] LoCsize:XL: > 1000 LoCThe logic is tested by #10760, which is pushed by a branch on
Apache/hudi(only this allows write permission in the workflow). The size label is added to all PRs now by running the action with a tweaked time window.Impact
Makes PR size labeling work and makes it easy to check PR size with the label and plan PR reviews based on estimated time required.
Risk level
none
Documentation Update
Will update README in a separate PR.
Contributor's checklist