Skip to content

[HUDI-7445] Move PR size labeling to GitHub scheduled workflow#10761

Merged
yihua merged 1 commit intoapache:masterfrom
yihua:HUDI-7445-move-size-labeling
Feb 27, 2024
Merged

[HUDI-7445] Move PR size labeling to GitHub scheduled workflow#10761
yihua merged 1 commit intoapache:masterfrom
yihua:HUDI-7445-move-size-labeling

Conversation

@yihua
Copy link
Copy Markdown
Contributor

@yihua yihua commented Feb 26, 2024

Change Logs

HOTFIX: SKIP AZURE CI
script update only

This PR moves the PR size labeling to the GitHub scheduled workflow, and the labeling logic is now implemented by ourselves instead of relying on third-party library.

The label is added based the lines of changes (LoC) of the PR (additions + deletions):

  • size:XS: <= 10 LoC
  • size:S: (10, 100] LoC
  • size:M: (100, 300] LoC
  • size:L: (300, 1000] LoC
  • size:XL: > 1000 LoC

The logic is tested by #10760, which is pushed by a branch on Apache/hudi (only this allows write permission in the workflow). The size label is added to all PRs now by running the action with a tweaked time window.

Impact

Makes PR size labeling work and makes it easy to check PR size with the label and plan PR reviews based on estimated time required.

Risk level

none

Documentation Update

Will update README in a separate PR.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

Copy link
Copy Markdown
Collaborator

@linliu-code linliu-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@hudi-bot
Copy link
Copy Markdown
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua force-pushed the HUDI-7445-move-size-labeling branch from 0f7282f to 09700ae Compare February 27, 2024 07:53
@yihua
Copy link
Copy Markdown
Contributor Author

yihua commented Feb 27, 2024

@stream2000 if you have time, you may review and approve another useful workflow logic to have, labeling PR size for planning PR reviews.

Copy link
Copy Markdown
Contributor

@stream2000 stream2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants