[HUDI-7551] Avoid loading all partitions in CleanPlanner when MDT is enabled#10928
Merged
danny0405 merged 3 commits intoapache:masterfrom Mar 28, 2024
Merged
[HUDI-7551] Avoid loading all partitions in CleanPlanner when MDT is enabled#10928danny0405 merged 3 commits intoapache:masterfrom
danny0405 merged 3 commits intoapache:masterfrom
Conversation
danny0405
reviewed
Mar 27, 2024
|
|
||
| String instantTime1 = "1"; | ||
| String fileName1 = | ||
| FSUtils.makeLogFileName(fileId, HoodieLogFile.DELTA_EXTENSION, instantTime1, 0, TEST_WRITE_TOKEN); |
Contributor
There was a problem hiding this comment.
Is there any testing for remote fs view?
Contributor
Author
There was a problem hiding this comment.
The remote fs view test class extends this one so it will also execute these tests
Collaborator
danny0405
approved these changes
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
This PR added a preloading from the MDT for the sake of performance but it also forces all the file group information into memory. This leads to higher memory usage than is required for the cleaner planner.
Changes in this PR:
Impact
Lowers amount of memory required for the cleaner planner
Risk level (write none, low medium or high below)
Low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist