Skip to content

Comments

[HUDI-7551] Avoid loading all partitions in CleanPlanner when MDT is enabled#10928

Merged
danny0405 merged 3 commits intoapache:masterfrom
the-other-tim-brown:HUDI-7551
Mar 28, 2024
Merged

[HUDI-7551] Avoid loading all partitions in CleanPlanner when MDT is enabled#10928
danny0405 merged 3 commits intoapache:masterfrom
the-other-tim-brown:HUDI-7551

Conversation

@the-other-tim-brown
Copy link
Contributor

Change Logs

This PR added a preloading from the MDT for the sake of performance but it also forces all the file group information into memory. This leads to higher memory usage than is required for the cleaner planner.

Changes in this PR:

  • Adds new method to load a list of partitions
  • Adds new endpoint for Remote FS View
  • Removes old load-all call in the CleanPlanner constructor

Impact

Lowers amount of memory required for the cleaner planner

Risk level (write none, low medium or high below)

Low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:M PR with lines of changes in (100, 300] label Mar 27, 2024

String instantTime1 = "1";
String fileName1 =
FSUtils.makeLogFileName(fileId, HoodieLogFile.DELTA_EXTENSION, instantTime1, 0, TEST_WRITE_TOKEN);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any testing for remote fs view?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remote fs view test class extends this one so it will also execute these tests

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-0.15.0 size:M PR with lines of changes in (100, 300]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants