[HUDI-210] Implement prometheus metrics reporter#1095
[HUDI-210] Implement prometheus metrics reporter#1095XuQianJin-Stars wants to merge 1 commit intoapache:masterfrom XuQianJin-Stars:HUDI-210
Conversation
|
hi, Thanks for opening the PR @XuQianJin-Stars, this test case is useless. Because PushGateway use For example, |
hudi-client/pom.xml
Outdated
There was a problem hiding this comment.
hi, this dependency can remove.
<dependency>
<groupId>io.prometheus</groupId>
<artifactId>simpleclient</artifactId>
</dependency>
|
hi @lamber-ken Thank you very much, Let me change it. |
well, you are right. I will remove this test. |
|
@lamber-ken @XuQianJin-Stars. Is it ready? |
Not yet. |
|
|
@XuQianJin-Stars What's the status of this PR? |
|
hi @leesf @lamber-ken Hive any time to continue review this PR? |
|
What is the status of this PR? Is it ready to merge? |
Due to conflicts, planning to resume work on this once https://issues.apache.org/jira/browse/HUDI-836 is done. |
|
@xushiyan hello,how is the progress |
Unfortunately I have to de-prioritize this as the test improvements are more needed at the moment. I may only be able to come back to this after a while. Please feel free to pick up the ticket in the mean time. Thanks. |
|
closing this one in favor of #1726 |
What is the purpose of the pull request
Since Prometheus is a very popular monitoring system and time series database, it would be better to provide a metrics reporter to report metrics to prometheus.
Brief change log
The changes are as follows:
Verify this pull request
This change added tests and can be verified as follows:
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.