Skip to content

[HUDI-7584] Always read log block lazily and remove readBlockLazily argument#11015

Merged
danny0405 merged 1 commit intoapache:masterfrom
wombatu-kun:HUDI-7584_always_read_log_block_lazily
Apr 15, 2024
Merged

[HUDI-7584] Always read log block lazily and remove readBlockLazily argument#11015
danny0405 merged 1 commit intoapache:masterfrom
wombatu-kun:HUDI-7584_always_read_log_block_lazily

Conversation

@wombatu-kun
Copy link
Contributor

Change Logs

Always read log block lazily and remove readBlockLazily argument

Impact

none

Risk level (write none, low medium or high below)

none

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@wombatu-kun wombatu-kun marked this pull request as draft April 14, 2024 09:30
@wombatu-kun wombatu-kun force-pushed the HUDI-7584_always_read_log_block_lazily branch from aafed3d to dde402b Compare April 14, 2024 09:40
@github-actions github-actions bot added the size:L PR with lines of changes in (300, 1000] label Apr 14, 2024
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@wombatu-kun wombatu-kun marked this pull request as ready for review April 14, 2024 13:41
@wombatu-kun
Copy link
Contributor Author

@yihua hi! You are the reporter of this task. Could you please review my PR?

Copy link
Contributor

@danny0405 danny0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the flag is still kept for different data blocks, shoule be fine.

@danny0405 danny0405 merged commit ad493d2 into apache:master Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L PR with lines of changes in (300, 1000]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants