Skip to content

[HUDI-391] Rename module name from hudi-bench to hudi-test-suite#1102

Merged
yanghua merged 1 commit intoapache:hudi_test_suite_refactorfrom
yanghua:HUDI-391
Dec 16, 2019
Merged

[HUDI-391] Rename module name from hudi-bench to hudi-test-suite#1102
yanghua merged 1 commit intoapache:hudi_test_suite_refactorfrom
yanghua:HUDI-391

Conversation

@yanghua
Copy link
Contributor

@yanghua yanghua commented Dec 12, 2019

What is the purpose of the pull request

Rename module name from hudi-bench to hudi-test-suite

Brief change log

  • Rename module name from hudi-bench to hudi-test-suite

Verify this pull request

This pull request is a trivial rework / code cleanup without any test coverage.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@yanghua
Copy link
Contributor Author

yanghua commented Dec 12, 2019

@n3nash Can you review this PR?

@n3nash
Copy link
Contributor

n3nash commented Dec 13, 2019

LGTM to me, couple of things to do before merging :

  1. Can you do a search of hudi-bench string in the module and make sure no comments are lingering that have this.
  2. The diff somehow doesn't show the module name change, I'm guessing that's just github and you've already made that ?

@yanghua
Copy link
Contributor Author

yanghua commented Dec 13, 2019

@n3nash

LGTM to me, couple of things to do before merging :

  1. Can you do a search of hudi-bench string in the module and make sure no comments are lingering that have this.

Yes, I have searched hudi-bench keyword and replaced all of them, there is nothing left.

  1. The diff somehow doesn't show the module name change, I'm guessing that's just github and you've already made that ?

Yes. I have renamed all of them, after merging, you can not find anything if you search bench keyword.

@yanghua yanghua merged commit ae5bd06 into apache:hudi_test_suite_refactor Dec 16, 2019
yanghua added a commit to yanghua/incubator-hudi that referenced this pull request Dec 24, 2019
yanghua added a commit that referenced this pull request Jan 14, 2020
yanghua added a commit to yanghua/incubator-hudi that referenced this pull request Feb 13, 2020
yanghua added a commit that referenced this pull request Feb 13, 2020
yanghua added a commit that referenced this pull request Feb 14, 2020
nsivabalan pushed a commit to nsivabalan/hudi that referenced this pull request Jan 9, 2025
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants