[HUDI-7668] Add and rename APIs in StorageConfiguration#11102
Merged
yihua merged 2 commits intoapache:masterfrom Apr 26, 2024
Merged
[HUDI-7668] Add and rename APIs in StorageConfiguration#11102yihua merged 2 commits intoapache:masterfrom
yihua merged 2 commits intoapache:masterfrom
Conversation
jonvex
reviewed
Apr 26, 2024
Contributor
jonvex
left a comment
There was a problem hiding this comment.
I feel like "newCopy()" should return a copy of the storageconfiguration not a copy of the underlying configuration.
maybe "getCopy()" would make more sense, because then it would match the wording with "get()"
Contributor
Author
As discussed offline, rename |
jonvex
approved these changes
Apr 26, 2024
Collaborator
yihua
added a commit
that referenced
this pull request
May 15, 2024
yihua
added a commit
that referenced
this pull request
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
This PR makes the following changes:
StorageConfiguration#newInstanceto create a newStorageConfigurationinstance with a new copy of the configuration.StorageConfiguration#setIfUnsetto set a property key with a value in the configuration, if the property key does not already exist.StorageConfiguration#gettoStorageConfiguration#unwrapfor readability.StorageConfiguration#newCopytoStorageConfiguration#unwrapCopyfor readability.Impact
New APIs to facilitate integration of
StorageConfiguration.Risk level
none
Documentation Update
none
Contributor's checklist