[HUDI-7710] Remove compaction.inflight from conflict resolution#11148
Merged
danny0405 merged 1 commit intoapache:masterfrom May 4, 2024
Merged
Conversation
Collaborator
danny0405
reviewed
May 4, 2024
| .findInstantsAfter(currentInstant.getTimestamp()) | ||
| .filterInflightsAndRequested() | ||
| .filter(i -> (!i.getAction().equals(COMPACTION_ACTION)) || i.getState().equals(REQUESTED)) | ||
| .getInstantsAsStream(); |
Contributor
There was a problem hiding this comment.
@linliu-code We still need to check the compaction for conflict correct? So instead of filtering out compaction.inflight, we should convert instant.compaction.inflight to instant.compaction.request for checking? Can you write a test case for this?
Contributor
There was a problem hiding this comment.
I guess if the compaction does not really execute before, there is no need to resolve the conflicts, because the log files would slice based on their specific completion time. If there is no confclits for the same file group from multiple writers, then we are good. @linliu-code , we can add some test cases to illustrate this.
danny0405
approved these changes
May 4, 2024
linliu-code
changed the title
compaction.inflight from conflict resolution
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
We filter it from
SimpleConcurrentFileWritesConflictResolutionStrategyclass.Impact
Fix a buggy process.
Risk level (write none, low medium or high below)
None.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist