[MINOR] Use parent as the glob path when full file path specified#11150
Merged
danny0405 merged 2 commits intoapache:masterfrom May 8, 2024
Merged
[MINOR] Use parent as the glob path when full file path specified#11150danny0405 merged 2 commits intoapache:masterfrom
danny0405 merged 2 commits intoapache:masterfrom
Conversation
Collaborator
danny0405
reviewed
May 5, 2024
| // Building HoodieFileIndex needs this param to decide query path | ||
| params.put("glob.paths", readPathString); | ||
| params.put("glob.paths", globPathString); | ||
|
|
Contributor
There was a problem hiding this comment.
do we have any test cases?
Contributor
Author
There was a problem hiding this comment.
I can't find a test class matching this class name. Is there a clustering test suite I should look in?
Contributor
There was a problem hiding this comment.
Not sure whether TestHoodieSparkMergeOnReadTableClustering is the candidate.
Contributor
Author
There was a problem hiding this comment.
Looks like it is already covered there
Contributor
There was a problem hiding this comment.
Fine, let's merge it first.
danny0405
approved these changes
May 8, 2024
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
yihua
pushed a commit
that referenced
this pull request
May 15, 2024
TheR1sing3un
pushed a commit
to TheR1sing3un/hudi
that referenced
this pull request
Feb 12, 2025
…ry-pick 1. introduce bucket-resizing procedure 2. optimize the configuration content when performing clustering with row writer, from apache#11614 3. use parent as the glob path when full file path specified, from apache#11150 4. resolve conflicts after cherry-pick Signed-off-by: liuchaoyang03 <liuchaoyang03@kuaishou.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Impact
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist