[HUDI-7797] Use HoodieIOFactory to return pluggable FileFormatUtils implementation#11302
Merged
yihua merged 2 commits intoapache:masterfrom May 26, 2024
Merged
Conversation
yihua
force-pushed
the
HUDI-7797-pluggable-format-utils
branch
from
6b8370a to
049a4ff
Compare
Collaborator
codope
reviewed
May 25, 2024
...ent/hudi-spark-client/src/main/java/org/apache/hudi/io/storage/HoodieSparkParquetReader.java
Outdated
Show resolved
Hide resolved
...nk-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/bootstrap/BootstrapOperator.java
Outdated
Show resolved
Hide resolved
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieAvroOrcReader.java
Outdated
Show resolved
Hide resolved
hudi-hadoop-common/src/main/java/org/apache/hudi/io/hadoop/HoodieAvroParquetReader.java
Outdated
Show resolved
Hide resolved
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/SparkHelpers.scala
Outdated
Show resolved
Hide resolved
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/SparkHelpers.scala
Outdated
Show resolved
Hide resolved
hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieMetadataTableValidator.java
Outdated
Show resolved
Hide resolved
yihua
changed the title
yihua
force-pushed
the
HUDI-7797-pluggable-format-utils
branch
from
049a4ff to
9800805
Compare
codope
approved these changes
May 25, 2024
Member
|
Thanks for addressing the comments. Please also update the PR description. |
Contributor
Author
|
Azure CI is green. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
This PR adds the flexibility to plug in custom
FileFormatUtilsimplementation based on theHoodieStorageinstance. To realize this, two new APIs#getFileFormatUtilsare added to theHoodieIOFactoryso that the IO factory implementation class can customize theFileFormatUtilsimplementation to return. The hardcoded logic inFileFormatUtils#getInstancefor Hadoop-based implementation is moved toHoodieHadoopIOFactoryclass. New tests are added inTestHoodieHadoopIOFactory.Impact
Allows pluggable
FileFormatUtilsimplementationRisk level
none
Documentation Update
none
Contributor's checklist