[MINOR] fix the error message for glue sync tool#11430
Closed
prabodh1194 wants to merge 1 commit intoapache:masterfrom
Closed
[MINOR] fix the error message for glue sync tool#11430prabodh1194 wants to merge 1 commit intoapache:masterfrom
prabodh1194 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
@prabodh1194 is this PR still in draft? |
prabodh1194
force-pushed
the
update_glue_sync_tool_err_msg
branch
from
5b0d785 to
8f2828f
Compare
Contributor
Author
nope. i just wanted to add a test case for this. couldn't do it yet. |
prabodh1194
force-pushed
the
update_glue_sync_tool_err_msg
branch
3 times, most recently
from
f269708 to
68f6048
Compare
Contributor
Author
|
@yihua can you please review this now. i finally figured out how to add the correct test case 😄 |
github-actions
bot
added
size:S
prabodh1194
changed the title
Contributor
Author
|
@danny0405 can you please review this 🙏🏼 |
danny0405
reviewed
Jul 1, 2024
| ddlExecutor = new JDBCExecutor(config); | ||
| break; | ||
| case GLUE: | ||
| throw new HoodieHiveSyncException("GLUE mode is supported in AwsGlueCatalogSyncTool class only. " |
Contributor
There was a problem hiding this comment.
Instread of throwing inside the HoodieHiveSyncClient, I'm wondering why we not just pick the right sync client in the caller.
Contributor
Author
There was a problem hiding this comment.
agreed. i can make that change :)
prabodh1194
force-pushed
the
update_glue_sync_tool_err_msg
branch
from
68f6048 to
74e0b63
Compare
Collaborator
Contributor
Author
|
since the other PR - #11543 is merged, this PR is not required anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
When I tried using
GLUEmode for syncing meta, I kept getting an error about entering an incorrect mode. I realised a but later that my--sync-tool-classessetting was not pointing toorg.apache.hudi.aws.sync.AwsGlueCatalogSyncTool. A better error message will go a long way in improve developer experience in this regard.Impact
Better error message. No public impact.
Risk level (write none, low medium or high below)
none.
Documentation Update
"none"
Contributor's checklist