[HUDI-7871] remove tableconfig from filegroup reader params#11449
Merged
jonvex merged 1 commit intoapache:masterfrom Jun 13, 2024
Merged
[HUDI-7871] remove tableconfig from filegroup reader params#11449jonvex merged 1 commit intoapache:masterfrom
jonvex merged 1 commit intoapache:masterfrom
Conversation
codope
approved these changes
Jun 13, 2024
yihua
reviewed
Jun 13, 2024
| Option<InternalSchema> internalSchemaOpt, | ||
| HoodieTableMetaClient hoodieTableMetaClient, | ||
| TypedProperties props, | ||
| HoodieTableConfig tableConfig, |
Contributor
There was a problem hiding this comment.
Could you think about simplifying all the parameters? The goal should be that given the file group ID and the query type with the reader context, storage instance, and the minimal set of configs (maybe with meta client), the file group reader should be able to figure out all necessary configs to fill in for reading the records out.
Contributor
Author
There was a problem hiding this comment.
Yeah, I can keep getting rid of more. Just want to keep the prs small
4 tasks
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
HoodieFileGroupReader has too many params.
We can get the tableconfig from the metaclient which is also a param.
Impact
Less params for fg reader
Risk level (write none, low medium or high below)
low
Documentation Update
N/A
Contributor's checklist