[MINOR] Removed useless checks from SqlBasedTransformers#11499
Merged
yihua merged 1 commit intoapache:masterfrom Jun 25, 2024
Merged
[MINOR] Removed useless checks from SqlBasedTransformers#11499yihua merged 1 commit intoapache:masterfrom
yihua merged 1 commit intoapache:masterfrom
Conversation
wombatu-kun
force-pushed
the
MINOR_fix_sqlbasedtransformers
branch
from
ca09e62 to
b0a476f
Compare
github-actions
bot
added
size:S
wombatu-kun
force-pushed
the
MINOR_fix_sqlbasedtransformers
branch
from
b0a476f to
3d4d5b8
Compare
yihua
requested changes
Jun 24, 2024
hudi-utilities/src/main/java/org/apache/hudi/utilities/transform/SqlFileBasedTransformer.java
Outdated
Show resolved
Hide resolved
hudi-utilities/src/main/java/org/apache/hudi/utilities/transform/SqlQueryBasedTransformer.java
Outdated
Show resolved
Hide resolved
hudi-utilities/src/main/java/org/apache/hudi/utilities/transform/SqlFileBasedTransformer.java
Show resolved
Hide resolved
wombatu-kun
force-pushed
the
MINOR_fix_sqlbasedtransformers
branch
from
3d4d5b8 to
c7ecfe4
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Removed checks in apply method of SqlQueryBasedTransformer and SqlFileBasedTransformer.
getStringWithAltKeysnever returnsnull, if there is no config in properties - it throws IllegalArgumentExceprion (property xxx not found), so null-checking of the result is unreachable (useless) here.Impact
none
Risk level (write none, low medium or high below)
none
Documentation Update
none
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist