try doing compcation once for batch mode#11520
Closed
hehuiyuan wants to merge 1 commit intoapache:masterfrom
Closed
try doing compcation once for batch mode#11520hehuiyuan wants to merge 1 commit intoapache:masterfrom
hehuiyuan wants to merge 1 commit intoapache:masterfrom
Conversation
Collaborator
danny0405
reviewed
Jun 27, 2024
|
|
||
| // try doing compcation once for batch mode | ||
| if (OptionsResolver.isMorTable(conf) && !conf.getBoolean(FlinkOptions.COMPACTION_ASYNC_ENABLED)) { | ||
| this.notifyCheckpointComplete(-1); |
Contributor
There was a problem hiding this comment.
If compaction is disabled, there might not be compaction sub-pipeline in the workload now.
yihua
reviewed
Sep 9, 2024
Contributor
yihua
left a comment
yihua
left a comment
There was a problem hiding this comment.
@danny0405 is the changes in this PR still useful?
Contributor
|
Not really, we can close it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Support to do compcation for batch mode
Impact
Risk level (write none, low medium or high below)
Documentation Update
Contributor's checklist