Skip to content

[HUDI-7998] fix insert overwrite hudi table with static partition whe…#11643

Merged
danny0405 merged 2 commits intoapache:masterfrom
KnightChess:fix-static-overwrite-error
Jul 19, 2024
Merged

[HUDI-7998] fix insert overwrite hudi table with static partition whe…#11643
danny0405 merged 2 commits intoapache:masterfrom
KnightChess:fix-static-overwrite-error

Conversation

@KnightChess
Copy link
Contributor

…n defining partition column with int type

Change Logs

fix #11623

Impact

None

Risk level (write none, low medium or high below)

None

Documentation Update

None

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:XS PR with lines of changes in <= 10 label Jul 17, 2024
@KnightChess KnightChess reopened this Jul 18, 2024
val partition = AttributeReference(k, partitionNameToType(k))()
val value = Literal(v)
val value = HoodieSqlCommonUtils.castIfNeeded(Literal.create(v), partitionNameToType(k))
EqualTo(partition, value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, can we add a UT test case?

Copy link
Contributor

@leesf leesf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified, LGTM

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@KnightChess KnightChess reopened this Jul 19, 2024
@danny0405 danny0405 merged commit 4588c35 into apache:master Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS PR with lines of changes in <= 10

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SUPPORT] Failed to insert overwrite hudi table when defining partition column with int type.

4 participants