[HUDI-7908] Hotfix: HoodieFileGroupReader fails if preCombine and partition fields are the same#11656
Merged
codope merged 1 commit intoapache:masterfrom Jul 20, 2024
Merged
Conversation
Merged
4 tasks
df61d27 to
459a581
Compare
459a581 to
7429cf5
Compare
…ields are the same (hotfix)
7429cf5 to
3af1b0c
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
From previous PR:
HoodieFileGroupReader failed if preCombine and partition fields are the same with IllegalArgumentException: Field: ts does not exist in the table schema. precombineField is required but it was filtered from dataSchema as other partition fields.
To fix this I made HoodieFileGroupReaderBasedParquetFileFormat do not filter partitionColumn from dataSchema if it is the same as preCombine field.
But I did it wrong, as you can see from this discussion: https://github.com/apache/hudi/pull/11473/files#r1681098941
There were 2 mistakes:
With this PR I fixed it.
Impact
precombineField and partition field may be the same, and it works with local spark and on cluster.
Risk level (write none, low medium or high below)
none
Documentation Update
none
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist