[HUDI-8015] Fix Glue Meta Sync Failure with recreating the table#11677
Merged
codope merged 3 commits intoapache:masterfrom Aug 8, 2024
Merged
[HUDI-8015] Fix Glue Meta Sync Failure with recreating the table#11677codope merged 3 commits intoapache:masterfrom
codope merged 3 commits intoapache:masterfrom
Conversation
CTTY
reviewed
Jul 25, 2024
| dropTable(tempTableName); | ||
| // drop and recreate the actual table | ||
| dropTable(tableName); | ||
| createTable(tableName, storageSchema, inputFormatClass, outputFormatClass, serdeClass, serdeProperties, tableProperties); |
Collaborator
Author
There was a problem hiding this comment.
Hi @CTTY, With the previous approach createOrReplaceTable is not functioning in the expected way. We observed that partitions are not dropped when the updateTable is called with latest properties. This is causing issues with the glue sync.
In this approach, we're dropping the table and creating the new table which should solve this issue.
vamsikarnika
changed the title
codope
reviewed
Jul 31, 2024
hudi-aws/src/main/java/org/apache/hudi/aws/sync/AWSGlueCatalogSyncClient.java
Show resolved
Hide resolved
Collaborator
codope
approved these changes
Aug 8, 2024
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Updated AwsGlueCatalaogSyncClient createOrReplace method to drop and create the table, instead of updating the table.
Updated the check to compare the base of the hudi table and metastore table location to ignore file schemas.
Impact
AWS Glue table will be dropped and recreated using the latest schema.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist