[MINOR] avoid repeated write behavior in ut#11755
Merged
danny0405 merged 1 commit intoapache:masterfrom Aug 13, 2024
Merged
Conversation
1. set stats in metadata after compaction 2. fix wrong usage about HoodieWriteMetadata which cause the repeated write behavior in ut Signed-off-by: ther1sing3un <ther1sing3un@163.com>
danny0405
reviewed
Aug 12, 2024
| compactionMetadata.setWriteStatuses(statuses); | ||
| compactionMetadata.setCommitted(false); | ||
| compactionMetadata.setCommitMetadata(Option.of(metadata)); | ||
| compactionMetadata.setWriteStats(updateStatusMap); |
Contributor
There was a problem hiding this comment.
Does line 116 already set up the write stat?
Member
Author
There was a problem hiding this comment.
Does line 116 already set up the write stat?
Yes, same stats value, but line 166 set up it in HoodieCommitMetadata but not in HoodieWriteMetadata. I think we should also set it in HoodieWriteMetadata.
Collaborator
KnightChess
reviewed
Aug 12, 2024
Contributor
KnightChess
left a comment
KnightChess
left a comment
There was a problem hiding this comment.
how about disable release cache data in compact ut?
Member
Author
Yes, it is also a great solution! But the |
danny0405
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I run a ut in
TestHoodieCompactor, I found that every compaction will write a same merged file 2 times.WriteStatus::collectis called after compaction.HoodieCompactor::compactChange Logs
Describe context and summary for this change. Highlight if any code was copied.
Impact
Describe any public API or user-facing feature change or any performance impact.
none
Risk level (write none, low medium or high below)
none
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist