[HUDI-8106] Use the new filegroup reader for the metadata table#11802
Closed
jonvex wants to merge 3 commits intoapache:masterfrom
Closed
[HUDI-8106] Use the new filegroup reader for the metadata table#11802jonvex wants to merge 3 commits intoapache:masterfrom
jonvex wants to merge 3 commits intoapache:masterfrom
Conversation
github-actions
bot
added
size:S
danny0405
reviewed
Aug 21, 2024
| } else { | ||
| Schema.createUnion(schema.getTypes.asScala.map(innerSchema => getAvroSchemaWithDefaults(innerSchema, dataType)).asJava) | ||
| }, containsNullSchema) | ||
| dataType match { |
Contributor
There was a problem hiding this comment.
Is this change Spark specific?
Contributor
Author
There was a problem hiding this comment.
kinda. It's because in the mdt we have a union of a bunch of different types, but otherwise, we expect union to only be 2 types with one of them being null. This is spark specific because this code is for converting spark schemas, but we will probably have an issue like this if other engines use a different schema than avro
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
use new fg reader for mdt
Impact
transition to fg reader for more use cases
Risk level (write none, low medium or high below)
medium
need to test more
Documentation Update
N/A
Contributor's checklist