Skip to content

[MINOR] Add remote file system props to meta sync properties#11846

Merged
yihua merged 1 commit intoapache:masterfrom
the-other-tim-brown:minor-meta-sync-properties
Sep 7, 2024
Merged

[MINOR] Add remote file system props to meta sync properties#11846
yihua merged 1 commit intoapache:masterfrom
the-other-tim-brown:minor-meta-sync-properties

Conversation

@the-other-tim-brown
Copy link
Contributor

@the-other-tim-brown the-other-tim-brown commented Aug 28, 2024

Change Logs

  • Pass through the properties for the remote file system view configuration if present to the meta sync properties so a meta sync can leverage this view if required

Impact

  • Allows meta syncs to leverage the existing remote file system view if one exists, this can allow the syncs to avoid creating their own file system view

Risk level (write none, low medium or high below)

Low

Documentation Update

N/A

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:XS PR with lines of changes in <= 10 label Aug 28, 2024
@the-other-tim-brown
Copy link
Contributor Author

@hudi-bot run azure

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

}
// Pass remote file system view properties to meta sync if present
if (writeClient.getConfig().getViewStorageConfig() != null) {
metaProps.putAll(writeClient.getConfig().getViewStorageConfig().getProps());
Copy link
Contributor

@danny0405 danny0405 Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the remote fs view config specified by user?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user will enable it but the configs are set when when initializing the remote server here: https://github.com/apache/hudi/blob/master/hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java#L1102-L1108

@yihua
Copy link
Contributor

yihua commented Sep 7, 2024

Azure CI is green.

@yihua yihua merged commit 61d1a7a into apache:master Sep 7, 2024
@the-other-tim-brown the-other-tim-brown deleted the minor-meta-sync-properties branch September 9, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS PR with lines of changes in <= 10

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants