[HUDI-8185] Handle Avro GenericData byte array comparison#11920
Merged
codope merged 1 commit intoapache:masterfrom Sep 10, 2024
Merged
[HUDI-8185] Handle Avro GenericData byte array comparison#11920codope merged 1 commit intoapache:masterfrom
codope merged 1 commit intoapache:masterfrom
Conversation
4 tasks
danny0405
approved these changes
Sep 10, 2024
852475a to
bcd917a
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
While building colstats for
bytesfield, we noticed that the comparison throws below exception:Byte arrays are not inherently comparable. So, we first need to wrap in
ByteBuffer. This PR fixes the issue and adds a simple comparison test.Impact
Fix byte array comparison (colstats is one use case).
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist