Skip to content

[HUDI-8402] Fix for CVE-2023-39410 and CVE-2020-13956#12010

Merged
danny0405 merged 2 commits intoapache:branch-0.xfrom
mehradpk:feature-cve-fix
Oct 22, 2024
Merged

[HUDI-8402] Fix for CVE-2023-39410 and CVE-2020-13956#12010
danny0405 merged 2 commits intoapache:branch-0.xfrom
mehradpk:feature-cve-fix

Conversation

@mehradpk
Copy link

Upgrade httpclient version to 4.5.13
Upgrade avro version to 1.11.3

Reference PR - #11964

Change Logs

This issue will address the below CVE from hudi-presto-bundle:0.14.0 jar
https://nvd.nist.gov/vuln/detail/CVE-2023-39410
https://nvd.nist.gov/vuln/detail/CVE-2020-13956

Impact

No user facing impacts

Risk level (write none, low medium or high below)

Included the new changes in presto and we haven't seen any regression issues

Documentation Update

None

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:XS PR with lines of changes in <= 10 label Sep 26, 2024
<hudi.spark.common.modules.1>hudi-spark3-common</hudi.spark.common.modules.1>
<hudi.spark.common.modules.2>hudi-spark3.2plus-common</hudi.spark.common.modules.2>
<avro.version>1.8.2</avro.version>
<avro.version>1.11.3</avro.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether spark-avro work with this, since 1.9, avro introduces many breaking change in their API.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danny0405 any specific workaround to verify if spark-avro is compatible and works fine with avro 1.11.3.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have deprecated Spark 2, 3.0 - 3.2 support, and the minimum Avro version used in Spark is 1.11.2. So I think this should be fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then we are fine, Flink also uses avro 1.11+

<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
<version>4.5.13</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only change the version in root POM.

<hudi.spark.common.modules.1>hudi-spark3-common</hudi.spark.common.modules.1>
<hudi.spark.common.modules.2>hudi-spark3.2plus-common</hudi.spark.common.modules.2>
<avro.version>1.8.2</avro.version>
<avro.version>1.11.3</avro.version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have deprecated Spark 2, 3.0 - 3.2 support, and the minimum Avro version used in Spark is 1.11.2. So I think this should be fine.

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@danny0405 danny0405 changed the title Fix for CVE-2023-39410 and CVE-2020-13956 [HUDI-8402] Fix for CVE-2023-39410 and CVE-2020-13956 Oct 22, 2024
@danny0405 danny0405 merged commit 92c7cae into apache:branch-0.x Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS PR with lines of changes in <= 10

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants