Skip to content

[HUDI-8331] Remove excessive table validity check#12078

Merged
yihua merged 4 commits intoapache:masterfrom
CTTY:ctty/hudi8331-rm-mdt-chk
Oct 11, 2024
Merged

[HUDI-8331] Remove excessive table validity check#12078
yihua merged 4 commits intoapache:masterfrom
CTTY:ctty/hudi8331-rm-mdt-chk

Conversation

@CTTY
Copy link
Contributor

@CTTY CTTY commented Oct 10, 2024

Change Logs

Remove TableNotFoundException#checkTableValidity and its usages.

This method is excessive because Hudi should just fail later on if this path is not valid/does not exist. This check is also problematic because it adds excessive FS calls, which can be very expensive when interacting with object stores like S3.

Impact

none

Risk level (write none, low medium or high below)

low

Documentation Update

none

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:S PR with lines of changes in (10, 100] label Oct 10, 2024
@danny0405
Copy link
Contributor

+1, makes sense.

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yihua yihua merged commit 9e65cb4 into apache:master Oct 11, 2024
@CTTY CTTY deleted the ctty/hudi8331-rm-mdt-chk branch October 12, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S PR with lines of changes in (10, 100]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants