[HUDI-8342] Log warning and skip building partition stats for non partitioned table#12089
Merged
nsivabalan merged 2 commits intoapache:masterfrom Oct 15, 2024
Merged
Conversation
yihua
reviewed
Oct 13, 2024
Contributor
yihua
left a comment
There was a problem hiding this comment.
Should we skip building partition stats index for non-partitioned table instead of throwing an error?
Member
Since we want to keep partition stats enabled by default, I think it makes sense to log a warning and skip building instead of failing. Otherwise, many new users will try out Hudi on non-partitioned table and they will have to manually disable it. |
Contributor
Author
|
partition stats is not enabled by default. So, I don't see it a strong reason from usability standup. |
acffc7a to
4dbdce9
Compare
4dbdce9 to
6358b87
Compare
codope
approved these changes
Oct 15, 2024
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Change Logs
Throwing exception for partition stats instantiation for non partitioned table
Impact
Throwing exception for partition stats instantiation for non partitioned table
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist