Skip to content

[HUDI-8342] Log warning and skip building partition stats for non partitioned table#12089

Merged
nsivabalan merged 2 commits intoapache:masterfrom
nsivabalan:partitionStatsNonPartitionedTable
Oct 15, 2024
Merged

[HUDI-8342] Log warning and skip building partition stats for non partitioned table#12089
nsivabalan merged 2 commits intoapache:masterfrom
nsivabalan:partitionStatsNonPartitionedTable

Conversation

@nsivabalan
Copy link
Contributor

Change Logs

Throwing exception for partition stats instantiation for non partitioned table

Impact

Throwing exception for partition stats instantiation for non partitioned table

Risk level (write none, low medium or high below)

low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:S PR with lines of changes in (10, 100] label Oct 13, 2024
Copy link
Contributor

@yihua yihua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we skip building partition stats index for non-partitioned table instead of throwing an error?

@codope
Copy link
Member

codope commented Oct 14, 2024

Should we skip building partition stats index for non-partitioned table instead of throwing an error?

Since we want to keep partition stats enabled by default, I think it makes sense to log a warning and skip building instead of failing. Otherwise, many new users will try out Hudi on non-partitioned table and they will have to manually disable it.

@nsivabalan
Copy link
Contributor Author

partition stats is not enabled by default. So, I don't see it a strong reason from usability standup.
but I am open to logging a warning and not throw an exception.

@codope codope force-pushed the partitionStatsNonPartitionedTable branch from acffc7a to 4dbdce9 Compare October 15, 2024 14:36
@codope codope changed the title [HUDI-8342] Throwing exception for partition stats instantiation for non partitioned table [HUDI-8342] Log warning and skip building partition stats for non partitioned table Oct 15, 2024
@codope codope force-pushed the partitionStatsNonPartitionedTable branch from 4dbdce9 to 6358b87 Compare October 15, 2024 14:59
@apache apache deleted a comment from hudi-bot Oct 15, 2024
@nsivabalan
Copy link
Contributor Author

image

@nsivabalan nsivabalan merged commit 16d686c into apache:master Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S PR with lines of changes in (10, 100]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants