Skip to content

[HUDI-8365] Reduce serialization overhead of HoodieTable#12095

Merged
danny0405 merged 3 commits intoapache:masterfrom
the-other-tim-brown:hoodie-table-serialization
Oct 17, 2024
Merged

[HUDI-8365] Reduce serialization overhead of HoodieTable#12095
danny0405 merged 3 commits intoapache:masterfrom
the-other-tim-brown:hoodie-table-serialization

Conversation

@the-other-tim-brown
Copy link
Contributor

@the-other-tim-brown the-other-tim-brown commented Oct 14, 2024

Change Logs

  • Lazily initialize the HoodieTableMetadata, HoodieIndex, and HoodieStorageLayout objects within the HoodieTable and avoid serializing it as part of the HoodieTable
  • Register classes referenced within HoodieTable and the HoodieTableMetaClient with Kryo

Impact

Reduces serialization overhead of Spark tasks that reference HoodieTable

Risk level (write none, low medium or high below)

Low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:S PR with lines of changes in (10, 100] label Oct 14, 2024
@the-other-tim-brown the-other-tim-brown changed the title Reduce serialization size of HoodieTable, add commonly serialized cla… Reduce serialization overhead of HoodieTable Oct 15, 2024
@the-other-tim-brown the-other-tim-brown changed the title Reduce serialization overhead of HoodieTable [HUDI-8365] Reduce serialization overhead of HoodieTable Oct 15, 2024
@the-other-tim-brown the-other-tim-brown marked this pull request as ready for review October 15, 2024 01:21
HoodieRecordGlobalLocation.class,
HoodieRecordDelegate.class
HoodieRecordDelegate.class,
HoodieInstant.class,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the criteria for adding these classes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kryo recommends registering the classes since it uses a shorter identifier instead of the fully qualified class name when serializing objects. I don't have any context for what the criteria is within the Hudi repo though.

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@danny0405 danny0405 merged commit 2e58340 into apache:master Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S PR with lines of changes in (10, 100]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants