Skip to content

[MINOR] Use HoodieStorage and StorageConf in HoodieCatalogTable#12181

Merged
danny0405 merged 1 commit intoapache:masterfrom
CTTY:ctty/catalog-storage
Oct 31, 2024
Merged

[MINOR] Use HoodieStorage and StorageConf in HoodieCatalogTable#12181
danny0405 merged 1 commit intoapache:masterfrom
CTTY:ctty/catalog-storage

Conversation

@CTTY
Copy link
Contributor

@CTTY CTTY commented Oct 30, 2024

Change Logs

Replace hadoopConf with storageConf in HoodieCatalogTable

Impact

none

Risk level (write none, low medium or high below)

none

Documentation Update

none

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@CTTY
Copy link
Contributor Author

CTTY commented Oct 30, 2024

Ideally I want to remove Hadoop classes from HoodieSqlCommonUtils completely, but I found HoodieStorage doesn't support makeQualified and requires larger refactoring: https://github.com/apache/hudi/pull/12181/files#diff-c2ae1c010600e66ba4a95258d85ad016eba5db58f32f5892690e51339b3cadeaL211

@github-actions github-actions bot added the size:S PR with lines of changes in (10, 100] label Oct 30, 2024
@wombatu-kun
Copy link
Contributor

@hudi-bot run azure

@danny0405
Copy link
Contributor

Ideally I want to remove Hadoop classes from HoodieSqlCommonUtils completely, but I found HoodieStorage doesn't support makeQualified and requires larger refactoring: https://github.com/apache/hudi/pull/12181/files#diff-c2ae1c010600e66ba4a95258d85ad016eba5db58f32f5892690e51339b3cadeaL211

Is it easy to copy that logic into Hudi then?

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@danny0405 danny0405 merged commit 8de012b into apache:master Oct 31, 2024
usberkeley pushed a commit to usberkeley/hudi that referenced this pull request Nov 13, 2024
@CTTY CTTY deleted the ctty/catalog-storage branch December 23, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S PR with lines of changes in (10, 100]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants