[HUDI-8513] Fix equals in HoodieRecordGlobalLocation

[linliu-code]

Change Logs

We remove the position from the equals function; otherwise, the workload profile will be huge and can cause OOM issue.

Impact

Better performance when using global indexes.

Risk level (write none, low medium or high below)

Low.

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

• The config description must be updated if new configs are added or the default value of the configs are changed
• Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
  ticket number here and follow the instruction to make
  changes to the website.

Contributor's checklist

• Read through contributor's guide
• Change Logs and Impact were stated clearly
• Adequate tests were added if applicable
• CI passed

[codope]

are there any side effects wrt positional deletes if we remove position from equals? Also, don't we need to keep the same fields in hashcode as well?

[linliu-code]

The hashCode function does not use position at the first place. Do not use any use case. HoodieRecordLocation has the same logic.

[danny0405]

If the position is not even used anywhere, we better remove it from the class, the only usage is from HoodieKeyLocationFetchHandle.globalLocations, where the getHoodieKeyIterator should be used instead of fetchRecordKeysWithPositions.

[linliu-code]

I meant the position is used from this class, but there should not be any cases where we need to group records at position level.

[danny0405]

I didn't see any usesage of the position outside this class, can you confirm that?

[yihua]

HoodieGlobalSimpleIndex#tagLocationInternal uses fetchRecordGlobalLocations which put the position of records into the HoodieRecordGlobalLocation instances. Such instance is later put into the corresponding HoodieRecord instance if the record is an update.

[linliu-code]

Re-trigger the CI.

[hudi-bot]

CI report:

• 8cad794 Azure: SUCCESS

Bot commands

@hudi-bot supports the following commands:

• @hudi-bot run azure re-run the last Azure build

[yihua]

HoodieGlobalSimpleIndex#tagLocationInternal uses fetchRecordGlobalLocations which put the position of records into the HoodieRecordGlobalLocation instances. Such instance is later put into the corresponding HoodieRecord instance if the record is an update.