[HUDI-8537] Alter table operation no need to do rollback for failed writes#12277
[HUDI-8537] Alter table operation no need to do rollback for failed writes#12277danny0405 merged 1 commit intoapache:masterfrom
Conversation
| val commitActionType = CommitUtils.getCommitActionType(WriteOperationType.ALTER_SCHEMA, metaClient.getTableType) | ||
| val instantTime = client.createNewInstantTime() | ||
| client.startCommitWithTime(instantTime, commitActionType) | ||
| client.startAlterTableWithTime(instantTime, commitActionType) |
There was a problem hiding this comment.
There is no need to introduce new APIs in base write client, just use startCommit should be fine. And it's not for clean but for rollback of failed writes.
Usually we have concurrent modifications to one table tween Flink pipeline and this alter table job, one solution is to config the rollback of failed writes as lazy, but fix here to remove the rollback should also be feasible.
There was a problem hiding this comment.
There is no need to introduce new APIs in base write client, just use
startCommitshould be fine. And it's not for clean but for rollback of failed writes.Usually we have concurrent modifications to one table tween Flink pipeline and this alter table job, one solution is to config the rollback of failed writes as lazy, but fix here to remove the rollback should also be feasible.
Alter table will involve rollback, clean, and archive, modify the paras will reduce the intrusiveness.
e16a22d to
ae01369
Compare
ae01369 to
f4ddd07
Compare
f4ddd07 to
986e4ca
Compare
986e4ca to
b44d362
Compare

Change Logs
When executing an alter-table- command, it is unnecessary to perform a clean operation.
This can mistakenly delete the regular files of the Flink stream-write task.
Impact
Describe any public API or user-facing feature change or any performance impact.
Risk level (write none, low medium or high below)
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist