[HUDI-8586] Allow partition stats only for primitive types#12350
Merged
codope merged 1 commit intoapache:masterfrom Nov 29, 2024
Merged
[HUDI-8586] Allow partition stats only for primitive types#12350codope merged 1 commit intoapache:masterfrom
codope merged 1 commit intoapache:masterfrom
Conversation
codope
force-pushed
the
hudi-8586-part-stats-data-types
branch
from
80dbf13 to
1393a72
Compare
codope
changed the title
github-actions
bot
added
size:M
nsivabalan
reviewed
Nov 28, 2024
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java
Show resolved
Hide resolved
nsivabalan
reviewed
Nov 28, 2024
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java
Show resolved
Hide resolved
| if ((fieldSchema.getType() == Schema.Type.INT || fieldSchema.getType() == Schema.Type.LONG) | ||
| && fieldSchema.getLogicalType() != null) { | ||
|
|
||
| // Skip fields with logical types DATE or TIME_MILLIS for INT, TIMESTAMP_MILLIS for LONG |
Contributor
There was a problem hiding this comment.
how did you arrive at this?
Member
Author
There was a problem hiding this comment.
I was checking the timestamop based logical types in avro - https://avro.apache.org/docs/1.11.0/spec.html#Logical+Types
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java
Outdated
Show resolved
Hide resolved
nsivabalan
approved these changes
Nov 28, 2024
ensure colstats enabled and fix logical types and add test address comments and fix some tests fix more tests fix testSecondaryIndexWithPartitionStatsIndex
codope
force-pushed
the
hudi-8586-part-stats-data-types
branch
from
c0f57c1 to
126bde5
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Impact
Partition stats correctness
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist