[HUDI-8605] Fix Trino failure when reading corrupted block at end of log file#12393
Open
usberkeley wants to merge 1 commit intoapache:masterfrom
Open
[HUDI-8605] Fix Trino failure when reading corrupted block at end of log file#12393usberkeley wants to merge 1 commit intoapache:masterfrom
usberkeley wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
@voonhous could you review this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Background
When a corrupted block appears at the end of a Log file, the Trino Reader (LogScanner) fails to read it. This is because Hudi attempts to use InputStream#seek to locate the end of the LogBlock to check for corruption. However, Trino's TrinoInputStream#seek does not necessarily throw an EOFException when seeking beyond the end of the file. In some file systems, such as AzureInputStream#seek and so on, it may throw an IOException, not an EOFException.
Why do we need this PR ?
The Trino issue is not unique, we might encounter custom InputStreams that encapsulate their own exception classes in reader. Therefore, we compare the position obtained from InputStream#getPos with the file length to determine if the end of the file has been reached
Impact
Fix Trino failure when reading corrupted block at end of log file
Risk level (write none, low medium or high below)
low
Documentation Update
none
Contributor's checklist