[HUDI-8678] feat: improve consistent-bucket resizing performance by reducing unnecessary record collecting#12451
Merged
danny0405 merged 4 commits intoapache:masterfrom Jan 6, 2025
Conversation
danny0405
reviewed
Dec 10, 2024
...ent-common/src/main/java/org/apache/hudi/table/ConsistentHashingBucketInsertPartitioner.java
Outdated
Show resolved
Hide resolved
TheR1sing3un
force-pushed
the
improve_consistent_clustering_by_reduce_collect
branch
from
16d1021 to
f457d79
Compare
github-actions
bot
added
size:M
…cessary record collecting 1. improve consistent-bucket resizing performance by reducing unnecessary record collecting Signed-off-by: TheR1sing3un <chaoyang@apache.org>
1. remove ConsistentHashingBucketInsertPartitioner Signed-off-by: TheR1sing3un <chaoyang@apache.org>
1. fix code style after rebasing master Signed-off-by: TheR1sing3un <chaoyang@apache.org>
TheR1sing3un
force-pushed
the
improve_consistent_clustering_by_reduce_collect
branch
from
f457d79 to
ededfcf
Compare
Member
Author
|
@danny0405 Hi, code has been updated according to your previous review, let's continue to review! |
danny0405
reviewed
Dec 24, 2024
...org/apache/hudi/execution/bulkinsert/ConsistentBucketIndexBulkInsertPartitionerWithRows.java
Outdated
Show resolved
Hide resolved
danny0405
reviewed
Dec 24, 2024
...main/java/org/apache/hudi/execution/bulkinsert/RDDConsistentBucketBulkInsertPartitioner.java
Outdated
Show resolved
Hide resolved
1. remove unused flag Signed-off-by: TheR1sing3un <chaoyang@apache.org>
Collaborator
danny0405
approved these changes
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When perform clustering to adjust bucket num for consistent-bucket, it is unnecessary to go through all the records to find the partitions to which the mapping relationship is to be loaded, because clustering plan already knows which partitions are required.
Change Logs
Describe context and summary for this change. Highlight if any code was copied.
Impact
Describe any public API or user-facing feature change or any performance impact.
none
Risk level (write none, low medium or high below)
none
If medium or high, explain what verification was done to mitigate the risks.
Documentation Update
none
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist