[HUDI-8776] Support inline path from SparkBroadcastManager#12501
Merged
jonvex merged 4 commits intoapache:masterfrom Dec 18, 2024
Merged
[HUDI-8776] Support inline path from SparkBroadcastManager#12501jonvex merged 4 commits intoapache:masterfrom
jonvex merged 4 commits intoapache:masterfrom
Conversation
danny0405
reviewed
Dec 17, 2024
| configurationBroadcast = jsc.broadcast(new SerializableConfiguration(hadoopConf)); | ||
|
|
||
| StorageConfiguration<Configuration> config = new HadoopStorageConfiguration(hadoopConf).getInline(); | ||
| configurationBroadcast = jsc.broadcast(new SerializableConfiguration(config.unwrap())); |
Contributor
There was a problem hiding this comment.
do we have some test for it.
linliu-code
force-pushed
the
ENG-18710
branch
from
6751ef8 to
67bb906
Compare
github-actions
bot
added
size:S
linliu-code
force-pushed
the
ENG-18710
branch
from
67bb906 to
9874ee8
Compare
linliu-code
force-pushed
the
ENG-18710
branch
from
9874ee8 to
59cdced
Compare
jonvex
reviewed
Dec 17, 2024
| return Option.of(configurationBroadcast.getValue().value()); | ||
| } | ||
|
|
||
| static Configuration getStorageConfiguration(Configuration configuration) { |
Contributor
There was a problem hiding this comment.
Can we change this name to "setSparkSqlConfigurations"?
Collaborator
Author
There was a problem hiding this comment.
I think it should be hadoopConfiguration based on jsc function. let me name it to hadoopConfiguration.
danny0405
approved these changes
Dec 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Add InlineFs related configurations for broadcast
Impact
Support inlineFs
Risk level (write none, low medium or high below)
Low.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist