Skip to content

[HUDI-8860] Avoid calling values() on ExternalSpillableMap#12626

Merged
codope merged 2 commits intoapache:masterfrom
codope:hudi-8860-file-slice-ext-map
Jan 14, 2025
Merged

[HUDI-8860] Avoid calling values() on ExternalSpillableMap#12626
codope merged 2 commits intoapache:masterfrom
codope:hudi-8860-file-slice-ext-map

Conversation

@codope
Copy link
Member

@codope codope commented Jan 13, 2025

Change Logs

Issue already fixed in 6db3751

Just adding a test.

Without the above fix, it leads to following exception

Caused by org.apache.hudi.exception.HoodieException: Unsupported Operation Exception
	at org.apache.hudi.common.util.collection.BitCaskDiskMap.values(BitCaskDiskMap.java:302)
	at org.apache.hudi.common.util.collection.ExternalSpillableMap.values(ExternalSpillableMap.java:290)
	at org.apache.hudi.common.table.log.LogFileIterator.hasNextInternal(LogFileIterator.java:44)
	at org.apache.hudi.common.table.log.LogFileIterator.doHasNext(LogFileIterator.java:55)
	at org.apache.hudi.common.table.log.HoodieFileSliceReader.hasNextInternal(HoodieFileSliceReader.java:90)
	at org.apache.hudi.common.table.log.HoodieFileSliceReader.doHasNext(HoodieFileSliceReader.java:95)
	at org.apache.hudi.common.table.log.CachingIterator.hasNext(CachingIterator.java:31)
	at org.apache.hudi.client.utils.ConcatenatingIterator.hasNext(ConcatenatingIterator.java:45)

Impact

Test coverage especially for clustering path with external spillable map

Risk level (write none, low medium or high below)

none

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:XS PR with lines of changes in <= 10 label Jan 13, 2025
@codope codope requested a review from jonvex January 13, 2025 12:42
@github-actions github-actions bot added size:M PR with lines of changes in (100, 300] and removed size:XS PR with lines of changes in <= 10 labels Jan 13, 2025
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@codope codope merged commit 8821c87 into apache:master Jan 14, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M PR with lines of changes in (100, 300]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants