Skip to content

[HUDI-7656] Fix a flaky test for concurrent writes#12655

Merged
nsivabalan merged 2 commits intoapache:masterfrom
linliu-code:HUDI-7656
Jan 22, 2025
Merged

[HUDI-7656] Fix a flaky test for concurrent writes#12655
nsivabalan merged 2 commits intoapache:masterfrom
linliu-code:HUDI-7656

Conversation

@linliu-code
Copy link
Collaborator

@linliu-code linliu-code commented Jan 16, 2025

Change Logs

Make sure the conflict happens since the update records are shared between the two writers.

Impact

Fix a flaky test.
Test locally for 40+ times; there are no failures.

Risk level (write none, low medium or high below)

None.

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:XS PR with lines of changes in <= 10 label Jan 16, 2025
yihua
yihua previously requested changes Jan 17, 2025
@linliu-code linliu-code requested a review from yihua January 17, 2025 01:03
@github-actions github-actions bot added size:S PR with lines of changes in (10, 100] and removed size:XS PR with lines of changes in <= 10 labels Jan 17, 2025
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

Copy link
Contributor

@nsivabalan nsivabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nsivabalan nsivabalan dismissed yihua’s stale review January 22, 2025 19:47

addressed your comments. moving ahead.

@nsivabalan nsivabalan merged commit e59764f into apache:master Jan 22, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S PR with lines of changes in (10, 100]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants