[HUDI-8883] Add ability to configure HoodieCompactionPlanGenerator using reflection#12664
Merged
nsivabalan merged 1 commit intoapache:masterfrom Feb 19, 2025
Merged
Conversation
danny0405
reviewed
Jan 18, 2025
| .getTime() / 1000; | ||
| } | ||
|
|
||
| private BaseHoodieCompactionPlanGenerator createCompactionPlanGenerator(String planGeneratorClass, HoodieTable table, HoodieEngineContext context, HoodieWriteConfig config) { |
Contributor
There was a problem hiding this comment.
We already have the stratefy classes why need to customize the plan generator?
Contributor
Author
There was a problem hiding this comment.
CompactionStrategy takes in the list of compaction operations and decides which ones to pick it up based on strategy logic. This is for the ability to keep track of metadata from previous compaction results in extraMetadata and then decide the plan.
Contributor
|
can you add PR desc please. |
nsivabalan
reviewed
Jan 31, 2025
Contributor
nsivabalan
left a comment
There was a problem hiding this comment.
does this reflect all latest changes.
1ad841b to
7beec7d
Compare
7beec7d to
cda0165
Compare
Collaborator
Contributor
nsivabalan
approved these changes
Feb 19, 2025
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 8, 2025
…ing reflection (apache#12664) (cherry picked from commit 5f64811)
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 9, 2025
…ing reflection (apache#12664) (cherry picked from commit 5f64811)
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 15, 2025
…ing reflection (apache#12664) (cherry picked from commit 5f64811)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Change Logs
Compaction Planners can make use of extraMetadata to decide which partitions/file groups to compact, eg: extraMetadata can be used to keep track of previous compaction results.
Impact
Provides ability to write compaction planner which can make use of extraMetadata to decide which partitions/file groups to compact.
Risk level (write none, low medium or high below)
Low
Documentation Update
Contributor's checklist