[HUDI-8962] Adding more logs during indexing#12787
Merged
nsivabalan merged 5 commits intoapache:masterfrom Feb 16, 2025
Merged
Conversation
989bf64 to
c633b6c
Compare
jonvex
reviewed
Feb 12, 2025
...-spark-client/src/main/java/org/apache/hudi/index/bloom/BucketizedBloomCheckPartitioner.java
Outdated
Show resolved
Hide resolved
jonvex
reviewed
Feb 12, 2025
...-client/src/main/java/org/apache/hudi/table/action/commit/BaseSparkCommitActionExecutor.java
Outdated
Show resolved
Hide resolved
jonvex
reviewed
Feb 12, 2025
hudi-common/src/main/java/org/apache/hudi/metrics/InMemoryMetricsReporter.java
Outdated
Show resolved
Hide resolved
jonvex
reviewed
Feb 12, 2025
hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/KafkaSource.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@jonvex : addressed all feedback |
Contributor
Author
|
@jonvex : addressed your feedback |
jonvex
requested changes
Feb 14, 2025
Contributor
jonvex
left a comment
There was a problem hiding this comment.
Get rid of "String.format(" the point is that no computation needs to be done unless the log level is info or debug. LOG.info will call format inside if necessary. So it should just be LOG.info("string {} with {} some {} args", arg1, arg2, arg3, arg4");
Collaborator
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 8, 2025
(cherry picked from commit af6768e)
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 9, 2025
(cherry picked from commit af6768e)
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 15, 2025
(cherry picked from commit af6768e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Adding more logs during indexing
Impact
Adding more logs during indexing
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist