Skip to content

[HUDI-8962] Adding more logs during indexing#12787

Merged
nsivabalan merged 5 commits intoapache:masterfrom
nsivabalan:oss-master-HUDI-8962
Feb 16, 2025
Merged

[HUDI-8962] Adding more logs during indexing#12787
nsivabalan merged 5 commits intoapache:masterfrom
nsivabalan:oss-master-HUDI-8962

Conversation

@nsivabalan
Copy link
Contributor

Change Logs

Adding more logs during indexing

Impact

Adding more logs during indexing

Risk level (write none, low medium or high below)

low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added size:S PR with lines of changes in (10, 100] size:M PR with lines of changes in (100, 300] and removed size:S PR with lines of changes in (10, 100] labels Feb 6, 2025
@github-actions github-actions bot added size:S PR with lines of changes in (10, 100] and removed size:M PR with lines of changes in (100, 300] labels Feb 12, 2025
@nsivabalan
Copy link
Contributor Author

@jonvex : addressed all feedback

@nsivabalan
Copy link
Contributor Author

@jonvex : addressed your feedback

Copy link
Contributor

@jonvex jonvex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get rid of "String.format(" the point is that no computation needs to be done unless the log level is info or debug. LOG.info will call format inside if necessary. So it should just be LOG.info("string {} with {} some {} args", arg1, arg2, arg3, arg4");

Copy link
Contributor

@jonvex jonvex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@nsivabalan nsivabalan merged commit af6768e into apache:master Feb 16, 2025
43 checks passed
voonhous pushed a commit to voonhous/hudi that referenced this pull request Apr 8, 2025
voonhous pushed a commit to voonhous/hudi that referenced this pull request Apr 9, 2025
voonhous pushed a commit to voonhous/hudi that referenced this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-1.0.2 size:S PR with lines of changes in (10, 100]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants