[MINOR] Fix flaky TestHoodieAvroDataBlock#12831
Merged
nsivabalan merged 1 commit intoapache:masterfrom Feb 12, 2025
Merged
Conversation
Collaborator
nsivabalan
approved these changes
Feb 12, 2025
Member
|
Removing release-1.0.2 tag for this as this PR is dependent on !11924 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Recently i faced this failure:
Error: TestHoodieAvroDataBlock.testGetRecordIteratorWithInputStream:188->verifyRecords:360 Record count mismatch ==> expected: <0> but was: <1000>That happened because of unnecessary random value generation in
selectRandomRecords: as a number of selected records was randomly generated 0 value, so it returned an empty listrecordsForFilter(andkeysForFilter). Later, when we calldataBlock.getRecordIteratorwith empty list askeysForFilter, it returns all records, and it causes records verification to fail.This PR fixes it by not using Random for generating number of selected records, just use value
allRecordsNum/4.Impact
fix flaky test
Risk level (write none, low medium or high below)
none
Documentation Update
none
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist