[HUDI-9141] Handle the case that dbName is empty in HoodieFileIndex#12885
Merged
danny0405 merged 4 commits intoapache:masterfrom Mar 12, 2025
Merged
[HUDI-9141] Handle the case that dbName is empty in HoodieFileIndex#12885danny0405 merged 4 commits intoapache:masterfrom
danny0405 merged 4 commits intoapache:masterfrom
Conversation
yihua
reviewed
Mar 4, 2025
Contributor
yihua
left a comment
There was a problem hiding this comment.
LGTM. Could you add a test case?
Contributor
|
Also, this is a bug fix so it's better to file and attach a JIRA ticket. |
93102a5 to
bf6f649
Compare
Contributor
|
@CTTY Can you take care of the test failures? |
dadcf60 to
1ce9d01
Compare
Collaborator
danny0405
approved these changes
Mar 12, 2025
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 8, 2025
…pache#12885) (cherry picked from commit ca24ab4)
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 9, 2025
…pache#12885) (cherry picked from commit ca24ab4)
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 15, 2025
…pache#12885) (cherry picked from commit ca24ab4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Database name can be null or empty, but in either case they should use the default value
default. Handle this corner case inHoodieFileIndexIssue this can cause:
Impact
None
Risk level (write none, low medium or high below)
None
Documentation Update
none
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist