Skip to content

Comments

[HUDI-9168] Refactor hudi-client-common to not import hudi-aws#12969

Merged
yihua merged 2 commits intoapache:masterfrom
alexr17:HUDI-9168/hudi-aws-dep-refactor
Mar 17, 2025
Merged

[HUDI-9168] Refactor hudi-client-common to not import hudi-aws#12969
yihua merged 2 commits intoapache:masterfrom
alexr17:HUDI-9168/hudi-aws-dep-refactor

Conversation

@alexr17
Copy link
Contributor

@alexr17 alexr17 commented Mar 13, 2025

Change Logs

This is an improvement PR to refactor the existing hudi-aws dependencies so we don't have circular imports when the S3 implementation of the lock provider using conditional writes is added.

Impact

hudi-aws is no longer a dependency of hudi-client-common

Risk level (write none, low medium or high below)

Medium, users which were transitively importing hudi-client-common through hudi-aws may face unexpected issues and need to add an additional dependency on hudi-client-common, however this dependency flow does not make sense, so this is a necessary breaking change.

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

None

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@github-actions github-actions bot added the size:M PR with lines of changes in (100, 300] label Mar 13, 2025
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@yihua yihua merged commit d4cf109 into apache:master Mar 17, 2025
43 checks passed
@alexr17 alexr17 deleted the HUDI-9168/hudi-aws-dep-refactor branch March 17, 2025 20:21
voonhous pushed a commit to voonhous/hudi that referenced this pull request Apr 8, 2025
voonhous pushed a commit to voonhous/hudi that referenced this pull request Apr 9, 2025
voonhous pushed a commit to voonhous/hudi that referenced this pull request Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-1.0.2 size:M PR with lines of changes in (100, 300]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants