[DNM][HUDI-9197] Fix flaky test for flink: testDynamicPartitionPrune#12995
Closed
cshuo wants to merge 2 commits intoapache:masterfrom
Closed
[DNM][HUDI-9197] Fix flaky test for flink: testDynamicPartitionPrune#12995cshuo wants to merge 2 commits intoapache:masterfrom
cshuo wants to merge 2 commits intoapache:masterfrom
Conversation
Collaborator
Author
|
cc @danny0405 |
4 tasks
cshuo
changed the title
github-actions
bot
added
size:XL
Collaborator
Author
|
@hudi-bot run azure |
github-actions
bot
added
size:XS
Collaborator
danny0405
reviewed
Mar 20, 2025
| TestData.writeData(TestData.DATA_SET_INSERT_SEPARATE_PARTITION, conf); | ||
| // stop the streaming query and get data | ||
| List<Row> actualResult = fetchResult(streamTableEnv, tableResult, 10); | ||
| List<Row> actualResult = fetchResult(streamTableEnv, tableResult, 60); |
Contributor
There was a problem hiding this comment.
60s is too long for the wait and sleeping.
Collaborator
Author
There was a problem hiding this comment.
I know, this is for just testing whether it's really failing because of timeout.
Now another failure test case arose: ITTestDataStreamWrite#testWriteMergeOnReadWithCompaction, need some deep diving.
Collaborator
Author
There was a problem hiding this comment.
ITTestDataStreamWrite#testWriteMergeOnReadWithCompaction is flaky because sometimes 35s is not enough to complete the compaction.
Collaborator
Author
|
Created a ticket HUDI-9205, we'll refactor flink continuous testing to avoid using sleeping for data results. This pr can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
When
read.streaming.enabledis enabled, flink incremental reading will continue running indefinitely until explicitly cancelled, and for IT test, we use sleep() to make sure expected data are read, but sometimes it's possible the program cannot finish reading data in the sleep interval. The fix here is an hotfix by increasing the sleep interval for the flaky test,and we may need more comprehensive solution to test the indefinitely incremental reading.
Impact
none
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist