[HUDI-9198] Support rate limit for append mode#12999
Merged
danny0405 merged 3 commits intoapache:masterfrom Mar 22, 2025
Merged
[HUDI-9198] Support rate limit for append mode#12999danny0405 merged 3 commits intoapache:masterfrom
danny0405 merged 3 commits intoapache:masterfrom
Conversation
cshuo
reviewed
Mar 21, 2025
| */ | ||
| public static <I> AppendWriteFunction<I> create(Configuration conf, RowType rowType) { | ||
| if (conf.getLong(FlinkOptions.WRITE_RATE_LIMIT) > 0) { | ||
| return new AppendWriteFunction<>(conf, rowType); |
Collaborator
There was a problem hiding this comment.
AppendWriteFunctionWithLimit for rate limit > 0?
Contributor
Author
There was a problem hiding this comment.
Oops, it's a mistake.
Contributor
Author
|
@zhangyue19921010 Can you review this for me? |
Contributor
Sure thing @danny0405 will review this PR |
zhangyue19921010
approved these changes
Mar 21, 2025
Contributor
zhangyue19921010
left a comment
zhangyue19921010
left a comment
There was a problem hiding this comment.
The code implementation is basically similar to RowDataToHoodieFunctionWithRateLimit
LGTM left a minor comment
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| /** | ||
| * Function that transforms RowData to a HoodieRecord with RateLimit. |
Contributor
There was a problem hiding this comment.
hhh need to change this java doc
github-project-automation
bot
moved this from 🆕 New
to 🛬 Near landing
in Hudi PR Support
Collaborator
github-project-automation
bot
moved this from 🛬 Near landing
to ✅ Done
in Hudi PR Support
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 8, 2025
(cherry picked from commit 5321605)
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 9, 2025
(cherry picked from commit 5321605)
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 15, 2025
(cherry picked from commit 5321605)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
Support rate limit for append mode
Impact
none
Risk level (write none, low medium or high below)
low