[HUDI-9216] Ignore validation of empty databaseName in HoodieTableMetaClient

[vinishjail97]

Change Logs

If user passes a different value of hoodie.database.name in properties, the validation can be ignored if tableConfig (content in hoodie.properties) contains null/empty string in it. This is primarily for use-cases, where there's an external table created with 0.x, initializing the table using 1.x adds hoodie.database.name in hoodie.properties as empty string and the validation keeps failing after that.

In the current PR we are removing both - the validation for empty hoodie.database.name and not setting hoodie.database.name in tableConfig if it's null or empty.

Impact

Low

Risk level (write none, low medium or high below)

Medium

Documentation Update

None.

Contributor's checklist

• Read through contributor's guide
• Change Logs and Impact were stated clearly
• Adequate tests were added if applicable
• CI passed

[yihua]

LGTM

[vinishjail97]

There are test failures looking into them.

Error:  Tests run: 18, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 5.096 s <<< FAILURE! - in org.apache.hudi.hadoop.TestGloballyConsistentTimeStampFilteringInputFormat
Error:  testIncrementalWithDatabaseName  Time elapsed: 0.241 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: The hoodie.database.name should be empty ==> expected: <> but was: <null>

[vinishjail97]

Azure CI failed with timeout. The flink IT's pass locally and are not related to this change. @yihua Can I push a retry for the failed ones ?

[yihua]

Azure CI failed with timeout. The flink IT's pass locally and are not related to this change. @yihua Can I push a retry for the failed ones ?

I rebased the branch on top of the latest master with CI improvements.

[hudi-bot]

CI report:

• 8ca830a Azure: SUCCESS

Bot commands

@hudi-bot supports the following commands:

• @hudi-bot run azure re-run the last Azure build

[yihua]

Flink IT flakiness is irrelevant. Merging the PR.