[HUDI-8990] PartitionBucketIndexManager Enhance #13106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@hudi-bot run azure |
danny0405
reviewed
Apr 10, 2025
|
|
||
| public static List<PartitionBucketIndexHashingConfig> getAllHashingConfig(HoodieTableMetaClient metaClient) throws IOException { | ||
| String basePath = metaClient.getBasePath().toString(); | ||
| List<StoragePath> allHashingConfig = getCommittedHashingConfigInstants(metaClient).stream().map(instant -> { |
Contributor
There was a problem hiding this comment.
allHashingConfig -> allHashingConfigPaths
danny0405
reviewed
Apr 10, 2025
| ValidationUtils.checkArgument(instantToLoad.isPresent(), "Can not load latest hashing config " + instantToLoad); | ||
| Option<PartitionBucketIndexHashingConfig> latestHashingConfig = loadHashingConfig(metaClient.getStorage(), getHashingConfigPath(metaClient.getBasePath().toString(), instantToLoad.get())); | ||
| ValidationUtils.checkArgument(latestHashingConfig.isPresent(), "Can not load latest hashing config " + instantToLoad); | ||
| Option<StoragePath> hashingConfigToLoad = getHashingConfigToLoad(metaClient, Option.empty()); |
danny0405
reviewed
Apr 10, 2025
| Option<PartitionBucketIndexHashingConfig> latestHashingConfig = loadHashingConfig(metaClient.getStorage(), | ||
| getHashingConfigPath(metaClient.getBasePath().toString(), hashingConfigInstantToLoad.get())); | ||
| ValidationUtils.checkArgument(latestHashingConfig.isPresent(), "Can not load hashing config " + hashingConfigInstantToLoad + " based on " + instant); | ||
| Option<StoragePath> hashingConfigToLoad = getHashingConfigToLoad(metaClient, Option.of(instant)); |
danny0405
reviewed
Apr 10, 2025
| dataFrame) | ||
|
|
||
| val details = s"Expression: $expression, Bucket Number: $bucketNumber, Dry Run: $dryRun" | ||
| val details = s"Expression: $expression, Bucket Number: $bucketNumber, Dry Run: $dryRun" |
Contributor
There was a problem hiding this comment.
is the option val case-sensitive from users?
Contributor
Author
There was a problem hiding this comment.
As a config name, it is case-sensitive.
To make it more user-friendly, change the config name from dryRun to dry_run like other Hoodie call command configs such as RollbackToSavepointProcedure => instant_time config name
Contributor
Author
|
@hudi-bot run azure |
danny0405
approved these changes
Apr 11, 2025
Contributor
|
The Azure CI failure is a known env issue: https://dev.azure.com/apachehudi/hudi-oss-ci/_build/results?buildId=4805&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Enhance PartitionBucketIndexManager Support
Impact
PartitionBucketIndexManager
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist