Skip to content

[MINOR] Overload HoodieFileGroupReader constructor to bring back old …#13116

Merged
codope merged 1 commit intoapache:masterfrom
voonhous:minor-restore-old-FgReade-api
Apr 10, 2025
Merged

[MINOR] Overload HoodieFileGroupReader constructor to bring back old …#13116
codope merged 1 commit intoapache:masterfrom
voonhous:minor-restore-old-FgReade-api

Conversation

@voonhous
Copy link
Member

@voonhous voonhous commented Apr 9, 2025

…API without allowInflightInstants parameter

Change Logs

Trino uses the HoodieFileGroupReader constructor. In #13010, the constructor signature was changed with an extra allowInflightInstants parameter.

Since this is a public facing API, this PR is bringing back the old signature, to maintain backwards compatibility.

Impact

None

Risk level (write none, low medium or high below)

None

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@voonhous voonhous self-assigned this Apr 9, 2025
@github-actions github-actions bot added the size:L PR with lines of changes in (300, 1000] label Apr 9, 2025
@voonhous voonhous force-pushed the minor-restore-old-FgReade-api branch from 021ef40 to a216f59 Compare April 9, 2025 09:42
@voonhous voonhous requested a review from codope April 9, 2025 09:42
@github-actions github-actions bot added size:S PR with lines of changes in (10, 100] and removed size:L PR with lines of changes in (300, 1000] labels Apr 9, 2025
@nsivabalan nsivabalan force-pushed the minor-restore-old-FgReade-api branch from a216f59 to 3feb0b7 Compare April 9, 2025 23:26
Copy link
Contributor

@nsivabalan nsivabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add a builder for the FG reader
https://issues.apache.org/jira/browse/HUDI-9285

@apache apache deleted a comment from hudi-bot Apr 10, 2025
@hudi-bot
Copy link
Collaborator

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@codope codope merged commit 3dcbd0f into apache:master Apr 10, 2025
60 checks passed
voonhous added a commit to voonhous/hudi that referenced this pull request Apr 10, 2025
…API without allowInflightInstants parameter (apache#13116)

(cherry picked from commit 3dcbd0f)
voonhous added a commit to voonhous/hudi that referenced this pull request Apr 11, 2025
…API without allowInflightInstants parameter (apache#13116)

(cherry picked from commit 3dcbd0f)
@voonhous voonhous deleted the minor-restore-old-FgReade-api branch April 14, 2025 02:27
voonhous added a commit to voonhous/hudi that referenced this pull request Apr 15, 2025
…API without allowInflightInstants parameter (apache#13116)

(cherry picked from commit 3dcbd0f)
voonhous added a commit to voonhous/hudi that referenced this pull request Apr 16, 2025
…API without allowInflightInstants parameter (apache#13116)

(cherry picked from commit 3dcbd0f)
voonhous added a commit to voonhous/hudi that referenced this pull request Apr 16, 2025
…API without allowInflightInstants parameter (apache#13116)

(cherry picked from commit 3dcbd0f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-1.0.2 size:S PR with lines of changes in (10, 100]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants