[HUDI-9323] Remove unnecessary config copying#13174
Merged
danny0405 merged 1 commit intoapache:masterfrom Apr 19, 2025
Merged
Conversation
f801d77 to
dff7444
Compare
dff7444 to
6f9863e
Compare
danny0405
approved these changes
Apr 19, 2025
voonhous
pushed a commit
to voonhous/hudi
that referenced
this pull request
Apr 20, 2025
(cherry picked from commit d847a76)
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Logs
This PR revisits all places using the constructors,
TypedProperties(Properties defaults)andHoodieConfig(Properties props), that involve copying the config values. Unnecessary config copying is removed. Detailed changes include:TypedProperties(Properties defaults)andHoodieConfig(Properties props)protected and addsTypedProperties#copyandHoodieConfig#copyso that developers know these APIs can be costly;HoodieAvroKeyGeneratorFactory.createKeyGenerator, usingConfigUtilson properties, newKeyGeneratorType#getKeyGeneratorClassNameAPI takingTypedProperties, etc.)Impact
Avoids unnecessary config copying and simplifies config passing.
Risk level
none
Documentation Update
N/A
Contributor's checklist